-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for general installation in containerized environments #3355
base: master
Are you sure you want to change the base?
Conversation
fa645e7
to
5e7da00
Compare
I am unable to figure out the reason for failure of check with: Any help to deal with this cryptic error is appreciated. |
Your files have extra spaces in them, at the ends of multiple lines.
That will edit the file, removing those extra unnecessary spaces. |
The extra spaces (particularly |
@olehermanse, Hope that's fine. |
What requirements? This is not required.
No, remove these, they are not necessary.
No, that change is not correct, remove it. We want to strip trailing whitespace. You don't need trailing whitespace nor html tags ( |
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@me-coder thank you for this contribution. Overall it's quite a nice addition. Looking forward to having this in the docs.
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
getting-started/installation/general-installation/installation-community-containerized.markdown
Outdated
Show resolved
Hide resolved
@@ -2,7 +2,7 @@ | |||
layout: default | |||
title: Installing Enterprise on CoreOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olehermanse Perhaps this should be re-titled to Installing Enterprise using disk image
Or actually, maybe we need to drop this page completely. I don't see that we are still publishing a disk image since CoreOS is died (and now it's resurrected under Fedora https://fedoraproject.org/coreos/ ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickanderson, it seems GitHub expects this review comment to be resolved for the review to be marked complete.
The link against requested change #3355 (review) which doesn't seem like the issue.
Can this be reconsidered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @me-coder I don't think it's because of this comment, just the other comments and suggestions in general where my review was set for requested changes.
Anyway, this comment had nothing to do with your PR. I just need to re-review.
Hi @olehermanse, @nickanderson, I made the suggested changes and also a few enhancements to the document and force pushed it as a amended single commit. I submitted a single commit as I always feel it's cleaner, could be fast-forwarded and there were changes which I could easily edit as a batch in VSCode editor. Kindly re-consider the review with the applied changes. |
Changes have been made, and re-review is needed.
I am traveling and I likely won't get around to looking at this again until next week at the very earliest if I manage to catch up with other things after travel. |
Hi @nickanderson , @olehermanse, @craigcomstock, |
The CFEngine installation guide is missing out on containers.
This PR is an attempt to project the capability of CFEngine with containers (using ubi9-init images).
There are a few limitations due to the nature of CFEngine (requires privileged mode and container is required to have systemd, which need initialization with /var/sbin/init).
However, it still gives a good ability to test CFEngine in containerized environments in full capacity, without the need to have a bulky multi VM setup.
Hope the moderator team finds this useful and decides to integrate it into the docs.