git promise type must just continue if we have unicode error

closes #99
cfengine · Aug 6, 2024 · 284cdb6 · 284cdb6
1 parent 2be0eee
commit 284cdb6
Showing 1 changed file with 14 additions and 9 deletions.
diff --git a/promise-types/git/git.py b/promise-types/git/git.py
@@ -236,16 +236,21 @@ def evaluate_promise(self, promiser: str, attributes: Dict, metadata: Dict):
 
     def _git(self, model: object, args: List[str], cwd: Optional[str] = None) -> str:
         self.log_verbose("Run: {cmd}".format(cmd=" ".join(args)))
-        output = (
-            subprocess.check_output(
-                args,
-                env=self._git_envvars(model),
-                cwd=cwd,
-                stderr=subprocess.PIPE,
+        try:
+            output = (
+                subprocess.check_output(
+                    args,
+                    env=self._git_envvars(model),
+                    cwd=cwd,
+                    stderr=subprocess.PIPE,
+                )
+                .strip()
+                .decode("utf-8")
             )
-            .strip()
-            .decode("utf-8")
-        )
+        except UnicodeDecodeError:
+            output = "Could not decode output, just continue"
+            pass
+
         output != "" and self.log_verbose(output)
         return output