Added package-module-winget and needed dependency powershell-execution-policy

[craigcomstock]

Ticket: ENT-12127

[nickanderson]

I think the module input hasn't yet been updated to target the data namespace.
Minor suggestion of style for README mentioning variables (use verbatim)

Overall seems to make sense to me.

[nickanderson]

Looks good enough to me (without running it). I would target data namspace explicitly with the module input.

And thinking about module input again, there must be some magic if it does default to the data namespace, because variables in def.json (where module input ultimately lands) default to the default namespace in the def bundle.

[nickanderson]

Actually I just ran a test with cfbs, and it seems that namespace is required for input.

$ cfbs build
Error in cfbs.json for module 'lynis': The "namespace" field is required in module input elements
WARNING: At least one error encountered while validating your cfbs.json file.
Please see the error messages above and apply fixes accordingly.
If not fixed, these errors will cause your project to not build in future cfbs versions.

Modules:
001 masterfiles @ d5d5c61942a97ec5e3fd35478e590c5943db5ac5 (Downloaded)
002 lynis       @ 4db6d515c45873a9f3fa7ce78ece593027464b64 (Downloaded)

Steps:
001 masterfiles : run 'EXPLICIT_VERSION=3.24.0 EXPLICIT_RELEASE=1 ./prepare.sh -y'
001 masterfiles : copy './' 'masterfiles/'
002 lynis       : copy 'policy/main.cf' 'masterfiles/services/lynis/main.cf'
002 lynis       : json 'cfbs/def.json' 'masterfiles/def.json'
002 lynis       : input './input.json' 'masterfiles/def.json'

Generating tarball...

Build complete, ready to deploy 🐿
 -> Directory: out/masterfiles
 -> Tarball:   out/masterfiles.tgz

To install on this machine: sudo cfbs install
To deploy on remote hub(s): cf-remote deploy

snippet of my cfbs.json whre I removed the namespace key for the input step for setting tar_url.

      "input": [
        {
          "type": "string",
          "namespace": "lynis",
          "bundle": "globals",
          "variable": "version",
          "label": "Lynis version",
          "question": "What version of Lynis should be used?",
          "default": "3.1.1"
        },
        {
          "type": "string",
          "bundle": "globals",
          "variable": "tar_url",
          "label": "Tarball url",
          "question": "Where should clients download lynis from (http/https)",
          "default": "https://downloads.cisofy.com/lynis/lynis-$(version).tar.gz",
          "comment": "Some may want to self host the tarball within their own infrastructure. This provides an easy way to do that. Note, the archive should be named for the version of Lynis selected."
        },

[nickanderson]

I think you must set namespace for module input.

[craigcomstock]

I didn't have to with cfbs 4.2.1 which is odd since we are both using that version. I suppose you are using a build index module and I am using a repo#commit. Maybe that's the diff.