Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class
cfengine_internal_purge_policies
would enable that feature on older versions of the MPF. When this feature was enabled files inside of /var/cfengine/inputs that did not exist on the servers /var/cfengine/masterfiles would be removed from the client, in effect a sync behavior instead of the default to just copy files on top if changes were made, leaving extra files alone.That default changed and so now that behavior is the default. If you previously had
cfengine_internal_purge_policies
defined then today you should simply disable the definition of that class to keep that sync behavior. Alternatively, if you desire the old behavior where extra files were not cleaned up then you would instead definecfengine_internal_purge_policies_disabled
.Since, this was enabling that feature which is now the default, I think that both of these should just be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After thinking about this for a moment another option would be to adjust
cfengine_internal_purge_policies
to targetcfengine_3_18
if the desire is to keep that behavior for older clients that may still be using this. Otherwise, still best to remove both i think.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed. I didn't read things quite right. Will adjust.