Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-11525: Added module to disable recommendations from the MPF #96

Merged

Conversation

nickanderson
Copy link
Member

@nickanderson nickanderson commented Apr 4, 2024

Ticket: ENT-11525
Changelog: Title

You can test this by adding my fork at the commit of the latest change, e.g.:

cfbs add https://github.com/nickanderson/modules@09b0a68d6cc16190f348878284a83bcfcddfffc0 disable-recommendations

Do we want this? I dunno, maybe it's better as a suggestion in MP rather than being a module. But we have other similar modules and I was just looking to improve quality of life for Vrata.

Ticket: ENT-11525
Changelog: Title
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise. Like I wrote somewhere else before, I think it would make more sense to have this as an input/parameter of the MPF module. But not a strong opinion.

management/disable-recommendations/README.md Outdated Show resolved Hide resolved
@olehermanse olehermanse merged commit b3af8bf into cfengine:master Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants