Add poc changes for [#177] #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertpl
commented
Oct 3, 2023
cjpatton
requested changes
Oct 5, 2023
There was a problem hiding this comment.
Looking good so far! Very clean for the most part. One high level ask: Please add more context to the commit message. A reference to the issue is somewhat useful, but it's helpful to have a summary of the change in the git log as well. (We rely on this heavily when preparing drafts.)
|
[Note, I will squash & summarize all changes in the commit, before merging this PR] |
albertpl
commented
Oct 6, 2023
cjpatton
reviewed
Oct 10, 2023
cjpatton
approved these changes
Oct 13, 2023
divergentdave
approved these changes
Oct 13, 2023
* Support multiproofs in Prio3 * Add new Prio3SumVec variant, i.e. Prio3SumVecWithMultiproof, with configuration (field size, number of proofs) * Add with_field class methods to introduce new SumVec with configurable field size
albertpl
force-pushed
the
poc-prio3-multiproof
branch
from
2ee0feb to
e11c788
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prio3Prio3SumVecvariant, i.e.Prio3SumVecWithMultiproof, with configuration (field size, number of proofs)with_fieldclass methods to introduce newSumVecwith configurable field size