Implement Prio3MultiHotHistogram that checks bounded number of 1s #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junyechen1996
force-pushed
the
junyec/multi-hot-histogram
branch
from
ea84cbb to
42443c5
Compare
wangshan
approved these changes
Oct 12, 2023
junyechen1996
force-pushed
the
junyec/multi-hot-histogram
branch
from
42443c5 to
f96ade5
Compare
cjpatton
reviewed
Oct 13, 2023
junyechen1996
commented
Oct 13, 2023
There was a problem hiding this comment.
@cjpatton Please also feel free to add David to review, since it's his idea. I don't have permission to add him.
cjpatton
reviewed
Oct 13, 2023
cjpatton
reviewed
Oct 13, 2023
divergentdave
approved these changes
Oct 13, 2023
junyechen1996
force-pushed
the
junyec/multi-hot-histogram
branch
from
764776f to
5073ea0
Compare
junyechen1996
commented
Oct 16, 2023
There was a problem hiding this comment.
Rebased on main. Also squashed commits because I have to resolve conflicts.
The remaining open question is this thread.
cjpatton
approved these changes
Oct 16, 2023
Add a reference implementation of the idea in issue cfrg#287, which needs a new FLP 'MultiHotHistogram' and a new Prio3 type 'Prio3MultiHotHistogram' that checks a Client's measurement has a bounded number of 1s.
junyechen1996
force-pushed
the
junyec/multi-hot-histogram
branch
from
c5332b4 to
14ca48c
Compare
|
Squashed. Should be good to merge after CI is completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a reference implementation of the idea in issue #287, which needs a new FLP 'MultiHotHistogram' and a new Prio3 type 'Prio3MultiHotHistogram' that checks a Client's measurement has a bounded number of 1s.