Point to test vectors rather than reproduce them #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
force-pushed
the
cjpatton/312
branch
2 times, most recently
from
f21f8e7 to
a7d9e68
Compare
|
Converted to draft while I incorporate some feedback from the list. |
cjpatton
force-pushed
the
cjpatton/312
branch
2 times, most recently
from
362f647 to
0571282
Compare
|
Rebased. |
bifurcation
approved these changes
Oct 1, 2024
divergentdave
approved these changes
Oct 1, 2024
The current plan is to reproduce the test vectors in the draft once we're ready for RFC. However the value of these test vectors for implementers is not clear. It would be better to publish machine-readable test vectors somewhere, point to it from the draft, and publish a hash of the test vectors in the draft so that implementers can use to verify their veracity. This commit implements the following idea: point to a commit hash for the draft and describe how to consume the test vectors. This commit also moves the VDAF test vectors to a directory that is easy to reference. Namely, we remove the sub-directory based on the version and add a `vdaf` sub-directory.
|
Squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #312.
The current plan is to reproduce the test vectors in the draft once
we're ready for RFC. However the value of these test vectors for
implementers is not clear. It would be better to publish
machine-readable test vectors somewhere, point to it from the
draft, and publish a hash of the test vectors in the draft so that
implementers can use to verify their veracity.
This commit implements the following idea: point to a commit hash for
the draft and describe how to consume the test vectors.
This commit also moves the VDAF test vectors to a directory that is easy
to reference. Namely, we remove the sub-directory based on the version
and add a
vdafsub-directory.