Histogram, MultihotCountVec: Move final reduction (*) #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
force-pushed
the
cjpatton/427-followup
branch
from
0bf9c64 to
3714407
Compare
|
Rebased. |
divergentdave
approved these changes
Oct 3, 2024
|
The sentence "All the individual checks are combined together in a random linear combination" in the Prio3Histogram section is technically still correct, but the random linear combination now happens both inside and outside the circuit, which could be a bit confusing. |
cjpatton
force-pushed
the
cjpatton/427-followup
branch
from
3714407 to
b3d9db2
Compare
|
Rebased. |
cjpatton
changed the title
Simplify the `Histogram` and `MultihotCountVec` circuits by moving the final reduction out of the circuit.
cjpatton
force-pushed
the
cjpatton/427-followup
branch
from
b3d9db2 to
31f39dc
Compare
Changed to "The individual checks constitute the output of the circuit." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #436 (merge that first)
Simplify the
HistogramandMultihotCountVeccircuits by moving the final reduction out of the circuit.