Clean up after full pass #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
requested review from
bifurcation,
divergentdave and
schoppmp
as code owners
cjpatton
force-pushed
the
cjpatton/draft-13/8
branch
2 times, most recently
from
969608a to
9416145
Compare
Miscellaneous improvements:
* Add an illustration of DAF preparation
* Clean up bounds on `run_daf()` and `run_vdaf()`
* Document only the pre-conditions that are relevant
* Remove code for enforcing the pre-conditions
* Use comments only for the stages of execution: sharding,
preparation, etc.
* Punt VDAF prep state listing to appendix
* Rename `encode_to_bit_vector()` to `encode_to_bit_vec()` for
consistency with abbreviation of "vector" to "vec" in other functions
* In titles, rename "Construction" to "Specification"
* In Prio3, list `prep_shares_to_prep()` before `prep_next()` so that
the computations are listed in chronological order. (We could do the
same for Poplar1, but there it's less helpful because we end up
calling `prep_next()` twice.)
cjpatton
force-pushed
the
cjpatton/draft-13/9
branch
from
d8942a2 to
10f1fd0
Compare
|
Rebased. |
divergentdave
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #498.
Miscellaneous improvements:
Add an illustration of DAF preparation
Clean up bounds on
run_daf()andrun_vdaf()Punt VDAF prep state listing to appendix
Rename
encode_to_bit_vector()toencode_to_bit_vec()for consistency with abbreviation of "vector" to "vec" in other functionsIn titles, rename "Construction" to "Specification"
In Prio3, list
prep_shares_to_prep()beforeprep_next()so that the computations are listed in chronological order. (We could do the same for Poplar1, but there it's less helpful because we end up callingprep_next()twice.)