Take some of @armfazh's suggestions for common conventions #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
requested review from
bifurcation,
divergentdave and
schoppmp
as code owners
armfazh
reviewed
Oct 15, 2024
armfazh
reviewed
Oct 15, 2024
armfazh
approved these changes
Oct 15, 2024
Closed
These changes are mostly for clarity, but there are a few things we had underspecified: * The length of the output of the little-endian and big-endian encoders was not specified. * How the length of the little-endian and big-endian decoders was interpreted was not specified. * the length of the output of `additive_secret_shares()` was ambiguous.
cjpatton
force-pushed
the
cjpatton/488
branch
from
8f4c9e6 to
3a994c8
Compare
|
Squashed. |
divergentdave
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #488.
cc @armfazh
These changes are mostly for clarity, but there are a few things we had underspecified:
The length of the output of the little-endian and big-endian encoders was not specified.
How the length of the little-endian and big-endian decoders was interpreted was not specified.
the length of the output of
additive_secret_shares()was ambiguous.