generated from martinthomson/internet-draft-template
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up references #508
Merged
Merged
Clean up references #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
requested review from
bifurcation,
divergentdave and
schoppmp
as code owners
October 16, 2024 20:34
cjpatton
added a commit
to ietf-wg-ppm/draft-ietf-ppm-dap
that referenced
this pull request
Oct 16, 2024
Make the terminology in the intro more consistent with the rest of the document, e.g., say "measurement" instead of "input". For the references (cf. cfrg/draft-irtf-cfrg-vdaf#508): * Use "refcontent" instead of "seriesinfo" for conferences * Use "name" instead of "ins" with the authors' full names as they appear in the references * Harmonize ordering and date format Tidy up the presentation language section: * We want to say "encoding and encoding of messages as bytes strings are as in RFC8446", but for some reason we say this into the second to last paragraph, between two exceptions to RFC8446 we want to document. Move this language up to the first paragraph.
divergentdave
approved these changes
Oct 17, 2024
* Use "refcontent" instead of "seriesinfo". The value is a string rather than a bunch of key/value pairs. In effect, this deletes the " " before the ",". * Put quotes around each "refcontent" value * Replace "ins" with "name" and use the author's full name as it appears in the reference. `xml2rfc` still wants to abbreviate the first name, but we at least preserve more information. * Add a "refcontent" for {{SML24}}. * Reorder {{MRH04}} fields to match the other references
cjpatton
force-pushed
the
cjpatton/ref-clean-up
branch
from
October 17, 2024 17:34
07cec03
to
92000ee
Compare
Merged
cjpatton
added a commit
to ietf-wg-ppm/draft-ietf-ppm-dap
that referenced
this pull request
Oct 17, 2024
Make the terminology in the intro more consistent with the rest of the document, e.g., say "measurement" instead of "input". For the references (cf. cfrg/draft-irtf-cfrg-vdaf#508): * Use "refcontent" instead of "seriesinfo" for conferences * Use "name" instead of "ins" with the authors' full names as they appear in the references * Harmonize ordering and date format Tidy up the presentation language section: * We want to say "encoding and encoding of messages as bytes strings are as in RFC8446", but for some reason we say this into the second to last paragraph, between two exceptions to RFC8446 we want to document. Move this language up to the first paragraph. Co-authored-by: Brandon Pitman <[email protected]>
cjpatton
added a commit
to ietf-wg-ppm/draft-ietf-ppm-dap
that referenced
this pull request
Oct 17, 2024
Make the terminology in the intro more consistent with the rest of the document, e.g., say "measurement" instead of "input". For the references (cf. cfrg/draft-irtf-cfrg-vdaf#508): * Use "refcontent" instead of "seriesinfo" for conferences * Use "name" instead of "ins" with the authors' full names as they appear in the references * Harmonize ordering and date format Tidy up the presentation language section: * We want to say "encoding and encoding of messages as bytes strings are as in RFC8446", but for some reason we say this into the second to last paragraph, between two exceptions to RFC8446 we want to document. Move this language up to the first paragraph. Co-authored-by: Brandon Pitman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #497.
Closes #503.
Use "refcontent" instead of "seriesinfo". The value is a string rather than a bunch of key/value pairs. In effect, this deletes the " " before the ",".
Put quotes around each "refcontent" value
Replace "ins" with "name" and use the author's full name as it appears in the reference.
xml2rfc
still wants to abbreviate the first name, but we at least preserve more information.Add a "refcontent" for {{SML24}}.
Reorder {{MRH04}} fields to match the other references