Poplar1: Move prefix order check to is_valid() #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divergentdave
requested review from
bifurcation,
cjpatton and
schoppmp
as code owners
cjpatton
reviewed
Oct 17, 2024
poc/tests/test_vdaf_poplar1.py
Outdated
Comment on lines
223
to
227
| # Test `is_valid` rejects unsorted prefixes. | ||
| agg_params = [ | ||
| (0, (int_to_bit_string(0b1, 1), int_to_bit_string(0b0, 1))), | ||
| ] | ||
| self.assertFalse(cls.is_valid(agg_params[0], list(agg_params))) |
There was a problem hiding this comment.
Somewhat random thought here: A quirk in Python's implementation of >= on tuples might mean these are not actually in lexicographic order. It might be worth expanding this to longer vectors, in particular checking that ordering starts with the front of the tuple rather than the end.
cjpatton
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #494.