Change measurement type of Prio3MultihotCountVec #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divergentdave
requested review from
bifurcation,
cjpatton and
schoppmp
as code owners
cjpatton
approved these changes
Oct 17, 2024
draft-irtf-cfrg-vdaf.md
Outdated
| non-zero. This allows Prio3MultihotCountVec to be composed with a randomized | ||
| response mechanism, like {{EPK14}}, for providing differential privacy. (For | ||
| example, each Client would set each entry to one with some small probability.) | ||
| For this instance of Prio3, each measurement is a vector of true and false |
There was a problem hiding this comment.
Or just "vector of bools" or "vector of booleans"
Suggested change
| For this instance of Prio3, each measurement is a vector of true and false | |
| For this instance of Prio3, each measurement is a vector of `True` and `False` |
draft-irtf-cfrg-vdaf.md
Outdated
| `max_weight`); and `chunk_length`, used the same way as in {{prio3sumvec}} and | ||
| {{prio3histogram}}. | ||
| `length`, the number of entries in the count vector; `max_weight`, the maximum | ||
| number of true entries (i.e., the weight must be at most `max_weight`); and |
There was a problem hiding this comment.
Suggested change
| number of true entries (i.e., the weight must be at most `max_weight`); and | |
| number of `True` entries (i.e., the weight must be at most `max_weight`); and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #506. Updating the commit hash of the test vectors will have to wait for a follow-up PR.