Editorial pass #521
Merged
Editorial pass #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An affine gadget would be a waste of a gadget check.
We already use "one-hot vector" elsewhere in this document to mean a vector with exactly one nonzero element, so we shouldn't overload this term.
The aggregate result may be influenced by attacker-controlled clients, but only insofar as honestly-generated reports could influence the aggregate result.
divergentdave
requested review from
bifurcation,
cjpatton and
schoppmp
as code owners
cjpatton
approved these changes
Nov 2, 2024
|
Yeah, looking at RFC 2119, maybe this ought to be a lower-case "should". There's no valid reason for an affine gadget, but also an affine gadget wouldn't break anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rolls up a bunch of editorial changes, clarifications, and rephrasings from my pass over the document. I split it out into several topical commits, plus a couple omnibus commits of more minor changes.