Skip to content

Commit

Permalink
mpegtsenc: Fix off-by-one in indexing into Opus channel mapping arrays
Browse files Browse the repository at this point in the history
Fixes, CID1338323, CID1338324

Signed-off-by: Michael Niedermayer <[email protected]>
  • Loading branch information
sdroege authored and michaelni committed Dec 4, 2015
1 parent 77a644e commit eb3628d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions libavformat/mpegtsenc.c
Original file line number Diff line number Diff line change
Expand Up @@ -401,11 +401,11 @@ static int mpegts_write_pmt(AVFormatContext *s, MpegTSService *service)

if (st->codec->extradata[19] == st->codec->channels - coupled_stream_counts[st->codec->channels] &&
st->codec->extradata[20] == coupled_stream_counts[st->codec->channels] &&
memcmp(&st->codec->extradata[21], channel_map_a[st->codec->channels], st->codec->channels) == 0) {
memcmp(&st->codec->extradata[21], channel_map_a[st->codec->channels-1], st->codec->channels) == 0) {
*q++ = st->codec->channels;
} else if (st->codec->channels >= 2 && st->codec->extradata[19] == st->codec->channels &&
st->codec->extradata[20] == 0 &&
memcmp(&st->codec->extradata[21], channel_map_b[st->codec->channels], st->codec->channels) == 0) {
memcmp(&st->codec->extradata[21], channel_map_b[st->codec->channels-1], st->codec->channels) == 0) {
*q++ = st->codec->channels | 0x80;
} else {
/* Unsupported, could write an extended descriptor here */
Expand Down

0 comments on commit eb3628d

Please sign in to comment.