Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added container (docker) functionality to the run statement #191

Merged
merged 12 commits into from
Dec 3, 2024

Conversation

Acribbs
Copy link
Contributor

@Acribbs Acribbs commented Dec 1, 2024

No description provided.

@Acribbs
Copy link
Contributor Author

Acribbs commented Dec 2, 2024

@david-cgat was this functionality that you had in mind? My other suggestion was to also include something like

# Configure container support
P.set_container_config(
    image="ubuntu:20.04",
    volumes=[
        "/data:/data",
        "/reference:/reference"
    ],
    env_vars={
        "THREADS": "4",
        "PATH": "/usr/local/bin:$PATH"
    }
)

So that you can use a container for the full pipeline. Then each task doesnt have to worry about what type of container is being ran and it doesnt need to be set for each function. Would be useful for small lightweight pipelines

@Acribbs Acribbs merged commit 243f74e into master Dec 3, 2024
14 checks passed
@Acribbs Acribbs deleted the AC-container branch December 3, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant