Champlain Final Project 1 420-N52-LA Pet Clinic repo
This project is based on the spring petclinic microservices (https://github.com/spring-petclinic/spring-petclinic-microservices) implementation. However, only the customers, visits, vets, and api-gateway services have been retained. In addition, the Docker setup has been changed.
For a User Story to be considered as DONE, all the following need to be met:
- A pull request has been made, reviewed and merged into Main.
- Any pull request that affects other teams' implementations needs to be reviewed by at least 1 member of each affected team.
- Implementations that require testing need 90% of Jacoco coverage.
- Merging does not cause any tests to fail.
- None of the previously implemented features ceased working unexpectedly.
- All the user acceptance criteria for the story are met.
Once you have cloned the repo (see the setup instructions below), you need to do the following:
In the project's top-level folder, you will need to create a file called mailer.env. It will contain SMTP_PASS property set to the hashed password of the mailing service you will be using. My students: I'll provide this to you.
Must be used prior to issuing a PR and in Sprint Reviews.
docker-compose build
docker-compose up -d
docker-compose logs -f
or
docker-compose up --build
This can be used during development to avoid having to rebuild everything whenever you make a change to the frontend.
docker-compose -f docker-compose_no_FE.yml build
docker-compose -f docker-compose_no_FE.yml up -d
docker-compose logs -f
or
docker-compose -f docker-compose_no_FE.yml up --build
React frontend:
localhost:3000/
Until it is fixed, to login on React frontend, use need to enter the following URI:
localhost:3000/users/login
Angular frontend:
localhost:8080/
In terminal:
Check database contents (did the script run)
winpty docker-compose exec mysql3 mysql -uuser -p customers-db -e "select * from owners"
winpty docker-compose exec mysql3 mysql -uuser -p customers-db -e "select * from pets"
winpty docker-compose exec mysql3 mysql -uuser -p customers-db -e "select * from types"
When all docker containers are up, test with curl:
curl localhost:8080/api/gateway/customer/owners | jq
curl localhost:8080/api/gateway/vet/vets | jq
- Please following standard naming convention as stated in the 'story workflow' section, and don't forget to label your pull requests
- We are all contributing to the same root project. If you break something, it will affect everyone. So, working on your own BRANCH is mandatory.
- The teams will self-name and come up with a four-letter acronym. The acronym will be called your TEAMTAG in these instructions.
- Each team is responsible for one or more microservices.
- Each team is responsible for implementing the UI for their features.
- Branches will be named according to the following convention: type/TEAMTAG-JiraID_Description
I like to break it down into 4 'folders' or types:
- feat/
- bug/
- doc/
- conf/
- After the slash, add your TEAMTAG
- After the TEAMTAG, add a slash and then the JIRA id (it will be something like CPC-4).
- The full branch name would look like this
feat/TEAMA-CPC-4_Add_Test_Scenario_New_Pet
and would be created and navigated to by executing the following command:
git checkout -b feat/TEAMA-CPC-4_Add_Test_Scenario_New_Pet
- To make it so we can easily search and find pull requests we will adhere to the following standard:
feat(TEAMTAG-JiraID): short description
- In that example, you would replace TEAMTAG with your team's acronym and the JIRA-TICKET-ID with the id from Jira.
- Keep the parentheses.
- Do not include any capital letters or punctuation in the description
- This is pretty much the exact same as the Pull Request Naming except that at the end there will be an auto-generated number in parentheses. Please don't delete it. Simply add your stuff before it.
feat(TEAMTAG-JiraID): short description (#420)
- First create an account on GitHub
- Download git https://git-scm.com/downloads
- Go to the official/ main repo https://github.com/cgerard321/champlain_petclinic
- Click the green button 'Code', and copy the given URL
- On your file explorer, navigate to where you want the project, right-click, and select 'git bash here'
- In the terminal window, type 'git clone' and then paste the copied url. (Do not ctrl + v to paste in the git bash terminal, it does not use standard windows encoding and will add extra invisible chars to the command causing it to error out.) It will look like this:
git clone https://github.com/cgerard321/champlain_petclinic
- The repo on your computer is known as the "local"
- The repo on GitHub is known as the "remote origin" or simply "origin"
- cd into the champlain_petclinic folder on your computer
cd champlain_petclinic/
To see that the remote origin has been correctly set up, type:
git remote add upstream https://github.com/cgerard321/champlain_petclinic.git
- If we type
git remote -v
we should see 4 different connections, push and fetch for our upstream and for our origin - Now that you have setup your clone, move on to the 'story workflow section'
- So you've setup your clone of the repo and started your first story. Now what?
- We will first navigate to our project in the file explorer, right-click, and select 'git bash here'
- In the current command line, you should see in parentheses, the branch you are currently on. We want to start this 'new story process' from our origin's main branch.
Christine@DESKTOP-2VF5PQD MINGW64 /e/champlain_petclinic (main)
- If it says main, great. Skip this next line. If not, type:
git checkout main
- This will simply transfer us to our origin's main branch
- Next, we will want to update our local project with any code our fellow devs have pushed while we were gone. To do this we must first 'download' the code using the following command:
git fetch origin main
- We are telling git to download the latest stuff from the main branch on our remote remote
- Then we want to actually start our story fresh with that code, so we will reset our local environment with that newly fetched code:
git reset --hard origin/main
-
It is also important to note this will reset any uncommited changes you've made, so keep that in mind. If you are following along and not starting a story from scratch, you might want to rebase instead. More info on rebasing can be found in the 'useful git commands' section
-
Now we will want to make a new branch to start working on our feature or bug fix. Simply type:
git switch -c YOUR-BRANCH-NAME
- This command is broken down into 2 parts,
checkout
will move you to a given branch the-b
modifier will create the branch - You have now created your new branch and are on it. Check the 'structure' section for what you should write in place of YOUR-BRANCH-NAME
- Now it's time to actually write some code. So go start implementing a new feature using TDD. Then come back after you're done.
- So now you have hopefully something done or at least the start to it and want to commit it
- First, we have to stage all edits, additions, and removals
git add .
- We can also stage specific files with a relative path
git add /path/to/file
- Next we will commit the code
git commit -m "A short description of what work was done in the commit"
-
After that you might repeat the
git add .
andgit commit
a couple times before your masterpiece is done -
When you are ready to show it to everyone else or if you want to be able to access it on another computer, we have to push it with this command: (it might ask you for login creds)
git push
-
Again this is the same this as saying
git push origin YOUR-BRANCH-NAME
theorigin
andYOUR-BRANCH-NAME
are implicitly applied -
If git gives you and error here telling you that you need to set the remote as upstream, simply copy/paste the command it gives you. Next time you push on this branch, you won't get this error.
-
Imagine at this point that everything in the story is done, and you are ready to get your code reviewed by the other devs. We need to make a pull request to do that
-
Go to your origin's github page (or project repo) and make a new pull request. At the top, verify that the branch (thing you want to compare) and base are all coming from and going to the correct place. "Compare" should be YOUR-BRANCH-NAME and "base" should be main.
-
Add a title as per the instructions in the 'structure' section, and make sure to add the label on the side bar, indicating which team you are on
-
In order to merge this Pull Request (PR), we need two other people to review and approve it. You can get other peoples attention by 'requesting a review' on the side bar or by sending them a DM in slack
-
Start by asking people on your team to do the review but don't hesitate to ask someone from a different team if there is an interaction
-
Once you've pleased everyone, your code is in prime condition, and you have no merge conflicts you can finally hit the 'squash and merge' button and set another title. Follow the naming conventions in the 'Pull Request Commit Naming' section of 'Structure'
-
Your PR is now merged and everyone can fetch and rebase or pull to see the work you've done
-
Congrats. Just repeat this process until the semester is over.
The commands are pretty much the same whether you are updating a branch, or you are trying to fix a merge conflict, except if you are updating you will skip the git add .
and the git rebase --continue
because you don't have anything to fix. You will still have to git push -f
Here's the scenario: Oh no, you have a merge conflict! This happens when you and another dev are working on the same file and edit the same line or git can't automatically figure out how to add your code and the main code together.
Once you see this error on your pull request, or if you happen to run into it outside of a PR, just follow these easy steps:
- First download the origin main data
git fetch origin main
- Next we will use the rebase command
git rebase origin/main
-
Git will now replay the commits of your branch on top of the origin main. If you have a merge conflict, the prompt will pause and tell you which files were affected. From there, just navigate to your file and update the code accordingly.
-
Once you have fixed all the merge conflicts go back to your terminal and type:
git add .
- Then
git rebase --continue
-
This command is telling git "ok I've fixed this conflict now move on to the next commit"
-
If you have more conflicts, repeat the last couple of steps, until the rebase is complete
-
Generally, you can tell the rebase is complete when you look at the branch name in your terminal, and it is the correct branch name i.e. without any extra text or random symbols
-
After that, the rebase has made a new local commit with all your changes, only one step left which is to force push:
git push -force-with-lease
-
This is just shorthand for this is done to only force push if the branch locally is not up to date with origin to not erase another persons commit if their on the same branch as you.
-
If you don't force push you'll get a bunch of red and yellow text like in the image below, which looks like you messed up, but it's fine. It didn't actually do anything just redo the command but with the
-f
- At this point, if you go back to your pull request, you should be able to automatically merge the branch.
This command lets you see any edited, added, or removed files:
git status
This will show you the differences between last commit (HEAD is main) and your local repo. Press q when you want to leave:
git diff HEAD .
This will list all your remotes:
git remote -v
This will list all your branches and there will be a star next to the branch you are currently on:
git branch
Reset your current branch to the upstream main:
git fetch origin main
git reset --hard origin/main
If you want to rebase the upstream main on top of your working branch:
git fetch origin main
git rebase origin/main
Switch to a branch:
git checkout BRANCH-NAME
Creating and switching to a branch:
git checkout -b BRANCH-NAME
Add all files ot be staged:
git add .
Remove all files from staging area:
git reset HEAD .
Commit all staged files:
git commit -m "My message"
Push code to remote repo:
git push
Push code to remote repo after rebase, use this one carefully:
git push --force
Select a specific commit and replay in onto a branch, don't include angled brackets:
git cherry-pick <commitId>
To save the stuff you have been working on if you need to quickly change branches but don't want to commit or want to transfer work from one branch to another, the basic is with git stash and there are a variety of variation you can look up but for general uses, this first command will store the data:
git stash
The next command will re-apply the data:
git stash pop
Note: This section is if you are using SSH keys to clone your repo and have already generated your GitHub SSH keys and ran your keygen in your terminal (console of your computer)
A common problem you face when setting the SSH key on the Mac is that when you restart your computer the ssh key makes you authenticate with your passphrase. To set the password and not make it ask for your passphrase everytime you run a command needing permissions. Run the command:
ssh-add
and enter your passphrase when prompted (Note: if you are not using the default filename, you'll need to specify your key filename ssh-add ~/.ssh/myprivatekeyname)
. The system will print Identity Added if successful.