fix: windows issues #446
Open
fix: windows issues #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 29, 2024
Open
cgrindel
reviewed
Jun 29, 2024
tests/bzlrelease_tests/rules_tests/release_artifact_tests/archive_test.sh
Outdated
Show resolved
Hide resolved
|
@cgrindel thanks for your review. It looks like a bunch of CI checks failed with an API key error, could you help with that? |
cgrindel
pushed a commit
to bazel-contrib/rules_bazel_integration_test
that referenced
this pull request
Jul 3, 2024
There are four issues when running on windows: 1. #330 2. #331 3. #332 4. #333 This PR fixes 3 and 4. There are related PRs in bazel-skylib and bazel-starlib. There is no dependency -- the PRs can close in any order. - cgrindel/bazel-starlib#446 (fixes 1) - bazelbuild/bazel-skylib#527 (fixes 2) ### Test results: Before: --enable_runfiles: 0 pass --noenable_runfiles: 0 pass After this PR: --enable_runfiles: 52 pass, 19 failures --noenable_runfiles: 51 pass, 20 failures (17 are doc diff-tests due to bazel-starlib) After this PR, together with wip PRs for 1 and 2: --enable_runfiles: 71 pass, 0 failures --noenable_runfiles: 51 pass, 20 failures (all due to bazel-starlib)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple issues on windows:
Issues 2-5 above are all fixed by this PR
Test results (windows)
(still filling in these results)
Before
--enable_runfiles 332 failures
--noenable_run
With buildifier_prebuilt update only
--enable_runfiles 116 failures
--noenable_run 154 failures + skips
With this PR only
--enable_runfiles 34 failures
--noenable_runfiles 122 failures + skips
With this PR and bazelbuild/bazel-skylib#527
--enable_runfiles 0 failures
--noenable_runfiles 85 failures
Future activity
Note: most of the --noenable_runfiles failures are of this form. It seems that bzlformat_lint_test.sh is designed to require runfiles.
Look into this: