Allow a pre-configured resty client instance to be injected #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, I believe this would also provide a workable solution to the issue described in #22 - clients wishing to skip debug logging would just need to use the newly-introduced function allowing them to inject their own |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it possible for consumers of this module to take advantage of features of go-resty/resty that are currently inaccessible due to the fact that the
resty.Clientinstance is inaccessible.The specifi feature that I'm hoping to use is retry support, which requires clients wishing to opt-in to call the
SetRetry*family of methods on theresty.Clientinstance. I'm also interested in using resty's middleware functionality.