Hosting/docker image Pull Request #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm! I've opened a new stretchgoal issue, so we don't lose sight of the fact that we could decrease the image size |
Courtsilius
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made
A docker file to generate a docker image was created from the node:alpine image and a docker-compose.yml file was created to enable storing the splats outside of the docker image to limit image size.
How to test
Copying the docker-compose.yml file into a folder with a
publicsubfolder that holds the splats you want to see should be enough. The image is stored on Dockerhub.Problems
The image is still rather large, even compressed (867.85 MB), partly due to still containing the test shoe. In the future the shoe could be removed, though for now it is useful for testing.
This solves #58