[qa] Fix tests

cgwire · Sep 18, 2024 · 1c16b81 · 1c16b81
1 parent b9802c4
commit 1c16b81
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/src/components/lists/AssetList.vue b/src/components/lists/AssetList.vue
@@ -228,7 +228,7 @@
           v-for="(group, k) in displayedAssets"
           v-if="!isLoading && isListVisible"
         >
-          <tr class="datatable-type-header">
+          <tr class="datatable-type-header" v-if="group[0]">
             <th scope="rowgroup" :colspan="visibleColumns">
               <span
                 class="datatable-row-header pointer"

diff --git a/src/store/modules/assets.js b/src/store/modules/assets.js
@@ -922,7 +922,7 @@ const mutations = {
       if (!isTime && asset.timeSpent > 0) isTime = true
       if (!isEstimation && asset.estimation > 0) isEstimation = true
       if (!isDescription && asset.description) isDescription = true
-      if (!isResolution && asset.data.resolution) isResolution = true
+      if (!isResolution && asset.data?.resolution) isResolution = true
     })
 
     const assetTypes = Array.from(assetTypeMap.values())

diff --git a/src/store/modules/tasktypes.js b/src/store/modules/tasktypes.js
@@ -33,7 +33,9 @@ const getters = {
   sequenceSubscriptions: state => state.sequenceSubscriptions,
 
   currentTaskType: (state, getters, rootState) => {
-    return state.taskTypeMap.get(rootState.route.params.task_type_id) || {}
+    const route = rootState.route || {}
+    const params = route.params || {}
+    return state.taskTypeMap.get(params.task_type_id) || {}
   },
 
   assetTaskTypes: (state, getters, rootState, rootGetters) => {

diff --git a/tests/unit/store/assets.spec.js b/tests/unit/store/assets.spec.js
@@ -791,10 +791,10 @@ describe('Assets store', () => {
       expect(state).toEqual({
         assetMap: new Map(),
         assetValidationColumns: [],
-        displayedAssets: [],
         assetFilledColumns: {},
         assetSearchFilterGroups: [],
         assetSearchQueries: [],
+        displayedAssets: [],
         displayedAssetsCount: 0,
         displayedAssetsLength: 0,
         displayedAssetsTimeSpent: 0,
@@ -987,6 +987,7 @@ describe('Assets store', () => {
         isAssetTime: false,
         isAssetEstimation: false,
         isAssetDescription: true,
+        isAssetResolution: false,
         assetValidationColumns: [],
         nbValidationColumns: 0,
         displayedAssets: store.cache.assets,
@@ -2002,6 +2003,7 @@ describe('Assets store', () => {
         isAssetDescription: false,
         isAssetEstimation: false,
         isAssetTime: false,
+        isAssetResolution: false,
         isAssetsLoading: false,
         isAssetsLoadingError: false,
         nbValidationColumns: 0,