Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: split out read config for easier testing #80

Merged
merged 11 commits into from
May 27, 2024
Merged

feat: split out read config for easier testing #80

merged 11 commits into from
May 27, 2024

Commits on May 27, 2024

  1. move read_config out of init for easier mocking

    @chadsr
    chadsr committed May 27, 2024
    Configuration menu
    Copy the full SHA
    79ce3af View commit details
    Browse the repository at this point in the history

  2. expand tests

    @chadsr
    chadsr committed May 27, 2024
    Configuration menu
    Copy the full SHA
    a91f67d View commit details
    Browse the repository at this point in the history

  3. always store coin symbols uppercase in config

    @chadsr
    chadsr committed May 27, 2024
    Configuration menu
    Copy the full SHA
    25911ff View commit details
    Browse the repository at this point in the history

  4. fixup tests

    @chadsr
    chadsr committed May 27, 2024
    Configuration menu
    Copy the full SHA
    ad4ad51 View commit details
    Browse the repository at this point in the history

  5. use mock patches instead of environ replace

    @chadsr
    chadsr committed May 27, 2024
    Configuration menu
    Copy the full SHA
    c3a735b View commit details
    Browse the repository at this point in the history

  6. prevent test api key clash

    @chadsr
    chadsr committed May 27, 2024
    Configuration menu
    Copy the full SHA
    d460d9e View commit details
    Browse the repository at this point in the history

  7. test cmc invalid key error

    @chadsr
    chadsr committed May 27, 2024
    Configuration menu
    Copy the full SHA
    db9933d View commit details
    Browse the repository at this point in the history

  8. store CI key secret in separate env

    @chadsr
    chadsr committed May 27, 2024
    Configuration menu
    Copy the full SHA
    05e6cb4 View commit details
    Browse the repository at this point in the history

  9. skip test_get_coinmarketcap_latest if no test key provided

    @chadsr
    chadsr committed May 27, 2024
    Configuration menu
    Copy the full SHA
    785cd51 View commit details
    Browse the repository at this point in the history

  10. only give coverage for main file

    @chadsr
    chadsr committed May 27, 2024
    Configuration menu
    Copy the full SHA
    3f70cd0 View commit details
    Browse the repository at this point in the history

  11. v1.5.1

    @chadsr
    chadsr committed May 27, 2024
    Configuration menu
    Copy the full SHA
    8c99386 View commit details
    Browse the repository at this point in the history