Fix for issue #214, request defaults not set when using Agent. #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything I can do to help out with this? I can make an intern write some tests, or stand on his head, or whatever. |
|
This looks great! But yes, let's get some tests in here before merging please! |
|
I think the tests on travis-ci are timing out randomly? :-/ |
|
I've tried re-running this and can confirm that it never passes on Travis's latest node and latest LTS images, yet the tests pass locally with those versions. Trying to figure out if this is a travis problem 🤷♂️. |
|
Odd, now the tests are actually failing, not just timing out. I guess that is better, we'll try to sort it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.