Run prettier as part of ESLint #1676
Conversation
|
i actually wouldn't do this i'd just one day really, prettier's eslint plugin/config should go away. since it should just be an automated thing run at the end |
koddsson
force-pushed
the
eslint-prettier
branch
from
d131eff to
029afe4
Compare
| "lint:js": "eslint lib/", | ||
| "lint:format": "prettier --check lib", | ||
| "lint:js": "eslint lib/ && prettier --check lib/", | ||
| "lint:format": "eslint lib/ --fix && prettier --write lib/", |
There was a problem hiding this comment.
This means the lint script will run both of them twice. I guess you meant to also update the lint script to only call lint:js?
Maybe we can make it clearer by calling the other lint:fix instead
There was a problem hiding this comment.
Oh maybe I've misunderstood how this works. I've been getting prettier changes in my PRs that didn't fail CI so I assumed it wasn't working but I can see now that it should be failing the build.
Maybe I was looking at the wrong thing then. I'm just gonna close this and add a git hook I think.
This way we get a failure in CI if the code isn't formatted according to prettier.