Add remove_data method #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @chaimleib,
Firstly, much thanks to you and co-contributors for building this excellent library.
I have a use case in which I want to delete intervals which are tagged with a certain data. The changes I propose add a remove_data(...) method which removes all intervals containing the data. If the optional set of points
pointsargument is filled, only intervals which overlap any of these points and also contain the given data will be removed. Providingpointslends a considerable speedup, as the only other way to remove points with certain data, as far as I can see, is to rebuild the entire tree.Please let me know your thoughts.