Update Python Versions #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 2.7, 3.4, 3.5, and 3.6 are end-of-life. And Pythons 3.10, 3.11 have been release. Python 3.12 is in alpha. See https://devguide.python.org/versions/ Note that Python 3.10/11/12 are on the next to latest version. The absolute latest versions have not been added to pyenv yet, and it probably doesn't matter.
| @@ -26,7 +26,7 @@ pip install intervaltree | |||
| Features | |||
| -------- | |||
|
|
|||
| * Supports Python 2.7 and Python 3.5+ (Tested under 2.7, and 3.5 thru 3.8) | |||
| * Supports Python 3.7+ (Tested under 3.7 thru 3.12) | |||
There was a problem hiding this comment.
The wording here isn't exactly symmetrical to the old version where 3.9 was in development, but we are testing 3.12 so I thought this was Ok to say.
| @@ -87,7 +87,7 @@ The two commands above run all the available tests on all versions of Python sup | |||
|
|
|||
| The first time you run `make`, you may be asked for your password. This is in order to install `pandoc`, a tool used for processing the README file. | |||
|
|
|||
| Running all tests requires that you have all the supported versions of Python installed. These are 2.6, 2.7, 3.2, 3.3, 3.4 and 3.5. Try to use your package manager to install them if possible. Otherwise, go to [python.org/downloads][] and install them manually. | |||
| Running all tests requires that you have all the supported versions of Python installed. These are 3.7 thru 3.12. Try to use your package manager to install them if possible. Otherwise, go to [python.org/downloads][] and install them manually. | |||
There was a problem hiding this comment.
Some of the wording here is out of date because now we use pyenv in the Makefile. But I wanted to keep the scope of the PR minimal and just change references to the Python versions.
|
Thanks for adding testing for newer versions of Python 3! If there is no reason break Python 2 support, I'd actually prefer to leave support in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the codebase and the build process to support the currently maintained Python versions, and drops support for unmaintained versions.
The important thing here is dropping 2.7 support. I went with the assumption that you are fine with that, but I am happy to remove the updates related to that if you want to keep supporting 2.7.