Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation rework in message comments & optimize Email type #32

Merged
merged 25 commits into from
Sep 24, 2024
Merged

Documentation rework in message comments & optimize Email type #32

merged 25 commits into from
Sep 24, 2024

Conversation

SamJaarsma
Copy link
Contributor

@SamJaarsma SamJaarsma commented Sep 17, 2024 •
edited by havan
Loading

  • The version in the header was updated to include the bot version that was used to generate the message.
  • Some pending fixme's and todo's were resolved
  • Added new item to ItemStatus enum in entry_requirements.proto
  • New version of file.proto with ImageFormat, VideoFormat, and Codec.

@SamJaarsma SamJaarsma requested review from havan and mo-c4t September 17, 2024 13:00
mo-c4t
mo-c4t reviewed Sep 18, 2024
View reviewed changes
proto/cmp/types/v1/email.proto Outdated Show resolved Hide resolved
proto/cmp/types/v1/common.proto Outdated Show resolved Hide resolved
proto/cmp/types/v1/change_policy.proto Outdated Show resolved Hide resolved
proto/cmp/types/v1/change_policy.proto Outdated Show resolved Hide resolved
proto/cmp/types/v1/email.proto Outdated Show resolved Hide resolved
@SamJaarsma SamJaarsma requested a review from mo-c4t September 18, 2024 13:28
@mo-c4t
Copy link
Member

mo-c4t commented Sep 18, 2024

which services will use email and file v2 ? don't we need to update them as well ?

Noctunus
Noctunus reviewed Sep 19, 2024
View reviewed changes
proto/cmp/types/v2/email.proto Outdated Show resolved Hide resolved
proto/cmp/services/info/v1/entry_requirements.proto Outdated Show resolved Hide resolved
@SamJaarsma SamJaarsma changed the title changed version documentation and resolved some fixmes and todos changed version documentation and resolved some fixes and todos Sep 20, 2024
@havan havan force-pushed the version-update branch 2 times, most recently from b42e9c5 to 6c7735f Compare September 23, 2024 20:53
havan
havan reviewed Sep 24, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
proto/cmp/types/v2/file.proto Outdated Show resolved Hide resolved
SamJaarsma and others added 18 commits September 24, 2024 15:30
@SamJaarsma @havan
[rebase] changed version documentation and resolved some fixme's and …
0cb524b 
…todo's
@SamJaarsma @havan
Update readme.md on github
84a8357
@SamJaarsma @havan
fix syntax error
ae14ce3
@SamJaarsma @havan
typo
612ed01
@SamJaarsma @havan
fix enum error
8ec0ad0
@SamJaarsma @havan
correction
c728667
@SamJaarsma @havan
format
c4446ff
@SamJaarsma @havan
correct file.proto version
394008c
@SamJaarsma @havan
typo2
6f37fb9
@SamJaarsma @mo-c4t @havan
Update proto/cmp/types/v1/email.proto
b7fc748 
Co-authored-by: Mohamed Elmoslemany <[email protected]>
@SamJaarsma @mo-c4t @havan
Update proto/cmp/types/v1/change_policy.proto
19fa866 
Co-authored-by: Mohamed Elmoslemany <[email protected]>
@SamJaarsma @mo-c4t @havan
Update proto/cmp/types/v1/change_policy.proto
0559cc7 
Co-authored-by: Mohamed Elmoslemany <[email protected]>
@SamJaarsma @havan
move changes in email.proto to v2alpha
be4478d
@SamJaarsma @havan
change v2alpha to v2
4b2d6ce
@SamJaarsma @havan
Push v2alpha to V2 for 3 files and 1 dependency
14f752e
@SamJaarsma @havan
dependencies fix
394590d
@SamJaarsma @havan
buf format
0bf877f
@havan
Fixing FQPN
c18ebc2
@havan havan changed the title changed version documentation and resolved some fixes and todos Documentation rework in message comments & optimize Email type Sep 24, 2024
@havan havan merged commit ca03e72 into dev Sep 24, 2024
6 of 8 checks passed
@havan havan deleted the version-update branch September 24, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noctunus Noctunus Noctunus left review comments

@mo-c4t mo-c4t mo-c4t approved these changes

@havan havan havan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SamJaarsma @mo-c4t @havan @Noctunus