Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Product List to AccommodationSearchParameters #7

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

SamJaarsma
Copy link
Contributor

Added Product List to AccommodationSearchParameters which was accidentally removed
Fixed a typo in the description of the AccommodationSearchParameters diagram

@SamJaarsma SamJaarsma requested a review from havan January 10, 2024 16:10
Copy link
Member

@havan havan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few suggestions and I also have a general concern: Is this message type a general one that will be used through different verticals or is it only related to Accommodation?

proto/cmp/types/v1alpha1/product_list.proto Outdated Show resolved Hide resolved
proto/cmp/types/v1alpha1/product_list.proto Outdated Show resolved Hide resolved
@SamJaarsma
Copy link
Contributor Author

SamJaarsma commented Jan 11, 2024

I've made a few suggestions
All agreed and implemented

Is this message type a general one that will be used through different verticals or is it only related to Accommodation?

ProductList can be used in any message type, if OTAs have the products of several suppliers mapped to their own product codes and descriptions. Also amended Transport and Activity Message Types.

A ProductList with one entry can be used to query for a specific hotel, flight, transfer, rent-a-car,... when the initial search is done from a cache file.

I also changed the filename from types/product_list.proto to types/product_code.proto

Copy link
Member

@havan havan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@havan havan merged commit 82d14dd into dev Jan 11, 2024
6 checks passed
@havan havan deleted the acommodation-product-list branch January 11, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants