Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search restructure with SearchQuery concept #8

Merged
merged 9 commits into from
Jan 17, 2024
Merged

Search restructure with SearchQuery concept #8

merged 9 commits into from
Jan 17, 2024

Conversation

havan
Copy link
Member

@havan havan commented Jan 12, 2024 •
edited
Loading

  • Updated search requests with introducing "query" concept to make it possible to have multiple queries per search request.
  • Update ServiceFact structure to have single field in messages and have enum types for charge basis and availability type.
  • Move content source type to generic search parameters so it's in every search request.
  • Add accommodation product extended info service.
  • Move Bed type out of accommodation package to generic types package.

@havan havan force-pushed the search-restructure branch from e0277aa to 02e1992 Compare January 13, 2024 01:56
@havan havan force-pushed the search-restructure branch from 5226831 to d5f9091 Compare January 15, 2024 12:49
@havan havan marked this pull request as ready for review January 17, 2024 11:45
@havan havan requested a review from SamJaarsma as a code owner January 17, 2024 11:45
SamJaarsma
SamJaarsma approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@SamJaarsma SamJaarsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@havan havan merged commit f20e9a1 into dev Jan 17, 2024
6 checks passed
@havan havan deleted the search-restructure branch January 17, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamJaarsma SamJaarsma SamJaarsma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@havan @SamJaarsma