Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suite #175

Merged
merged 8 commits into from
Dec 11, 2023
Merged

Suite #175

merged 8 commits into from
Dec 11, 2023

Conversation

Ayagoumi
Copy link

@Ayagoumi Ayagoumi commented Dec 8, 2023 •
edited
Loading

Msig Minor Bug Fixes (#167)

Changes

  • Settings and Route Naming

    • Updated terminology: "platform" to "Network" in settings.
    • Renamed the route to "manage-multisig".

  • UI and Functionality Fixes

    • Eliminated <div> within <p> bug.
    • Ensured fetching of aliases only for logged-in users.
    • Enhanced UX by closing the drawer when executing an action.

Additional Pull Requests

Close Drawer for Desktop View (#169)

  • Implemented handleCloseSidebar for desktop view.

Foundation Route Addition (#117)

  • Added foundation route to the app selectors.

Partner Display Fix (#170)

  • Fixed issue with displaying partners while logged in.
  • Adjusted subtext of the foundation card for better clarity.

Font Styling Changes (#89)

  • Overhauled font styling across the application.
  • Adjusted typography size in the footer for better readability.

Enhancements in Offer Creation (#171)

  • Integrated navigate function into create offer form params.

Landing Page App Selection Fix (#174)

  • Resolved issue with changing the app selected on the landing page.

Ayagoumi and others added 7 commits October 5, 2023 23:04
@Ayagoumi @mo-c4t
Msig minor bug fixes (#167)
7f7e45c 
* fix: Update "platform" to "Network" in settings & rename route to "manage-multisig"

* fix: Eliminate <div> within <p> bug & fetch aliases only for logged-in users

* fix: close drawer when executing an action
@Ayagoumi @mo-c4t
fix: add handleCloseSidebar for desktop view (#169)
dc6e944
@aeddaqqa
add foundation route to the app selectors (#117)
5b13c19
@aeddaqqa
fix display partners while logged in (#170)
06a6ad8 
* fix display partners while logged in

* adjust subtext of foundation card
@aeddaqqa @Ayagoumi
change font styling (#89)
4fc5da4 
* change font styling

* fix(footer): typography size adjustment

---------

Co-authored-by: Ayagoumi <[email protected]>
@aeddaqqa
add navigate function to create offer form params (#171)
67b554b 
* add navigate function to create offer form params

* fix catch fetching multisig aliases error
@aeddaqqa
fixe change the app selected in landing page (#174)
bf58086
@Ayagoumi Ayagoumi requested a review from aeddaqqa December 8, 2023 09:16
@Ayagoumi Ayagoumi requested a review from mo-c4t December 11, 2023 14:15
@Ayagoumi Ayagoumi merged commit 22544fb into suite-c4t Dec 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mo-c4t mo-c4t mo-c4t approved these changes

@aeddaqqa aeddaqqa Awaiting requested review from aeddaqqa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ayagoumi @mo-c4t @aeddaqqa