Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: header state issue when navigating back to explorer from wallet #186

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Ayagoumi
Copy link

Issue Description:

We identified a bug in our application where navigating from the explorer to the wallet using the navigation dropdown and then returning to the explorer using the browser's back button results in the explorer displaying an incorrect wallet header.

Steps to Reproduce:

  • Go to the explorer page in the application.
  • Use the navigation dropdown to switch to the wallet page.
  • Utilize the browser's back button to return to the explorer page.

Observed Behavior:

After following the above steps, the explorer page incorrectly displays the wallet header.

Expected Behavior:

The explorer page should maintain its original header after navigating back from the wallet page.

Fix Description:

This PR addresses the issue by ensuring proper state management and header rendering when navigating between pages. We've added a check to reset the header state when the explorer page is revisited via the browser's back button.

@Ayagoumi Ayagoumi requested a review from aeddaqqa January 16, 2024 11:37
Copy link

@aeddaqqa aeddaqqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ayagoumi Ayagoumi merged commit 99eebac into suite Jan 18, 2024
4 checks passed
@Ayagoumi Ayagoumi deleted the fix/explorer-wallet-header-navigation branch January 18, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants