Suite #190
Merged
Suite #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: app configuration and routing * feat: add loading indicator to when the networks are loading or on network change
add update wallet name to wallet component methods
fix switching to logged in network
* feat: change theme to dark/light instead of day/night * refactor: transaction list selector cypress test * Refactor theme switcher and main layout styles
* feat: inability to create a new network with the same infos as a known network * fix: set default theme & and set a default data-theme when it's not set * feat(switch network): persist selected network name to localStorage * feat: change validation rules of adding a new custom network
fix update name of the wallet even if its singlesig
… LandingPage layout and content (#187)
add new custom hook for handling actions in wallet
Ayagoumi
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request encompasses a variety of enhancements, fixes, and refactoring efforts aimed at improving the overall functionality, user experience, and maintainability of the application. Here's a concise overview of the changes:
Refactor app configuration and routing
Fix issues related to changing wallet name or address when switching wallets
Addresses bugs causing incorrect updates to wallet name or address upon switching wallets.
Resolve issues with switching to the logged-in network
Introduce methods for updating the wallet name within the wallet component
Adds new methods to the wallet component facilitating the update of wallet names.
Change theme options to dark/light for improved clarity
Ensure proper update of wallet name even for single-signature wallets
Fix header state inconsistency when navigating back to explorer from wallet
Refactor Footer and Navbar components, revamp Landing Page layout and content
Introduce a new custom hook for handling wallet actions
Set default theme and data-theme
Persist network selection in local storage implements functionality to persist network selection in local storage, enhancing user convenience.
These changes collectively contribute to a more robust, user-friendly, and maintainable application.