Business fixes #291
Merged
Business fixes #291
+1,020
−927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Redux for state management - Replaced local state management in BusinessFieldFilter with Redux state using `useAppSelector` and `useAppDispatch`. - Updated PartnersFilter to utilize Redux for managing company name and filter states. - Refactored SearchInput to use a controlled component approach with props for value and change handling. - Enhanced partnersReducer to handle business fields more effectively, including new helper functions for toggling fields and resetting selections. - Adjusted selectors to accommodate the new state structure and ensure proper filtering of partners based on updated criteria.
…components - Added new properties to PartnerDataType: isOnMessenger, wantedServices, supportedServices, and supportedCurrencies. - Updated BusinessFieldFilter to improve layout and responsiveness, including adjustments to width and MenuProps for better UX. - Refactored PartnerBusinessFields to handle optional chaining for business fields data. - Enhanced PartnersFilter to utilize Redux for partner data selection, improving state management. - Updated selectors and services to streamline partner data retrieval based on company name and cChain address. - Improved overall component structure and import organization for better maintainability.
- Removed unnecessary loading state checks and improved the conditional rendering in the PartnersLayout and MatchingPartners components. - Updated the useEffect in PartnersLayout to fetch partners and business fields only when the active network is available. - Refactored partner selectors to enhance filtering capabilities, including optional chaining for safer data access. - Streamlined the integration of Redux for managing partner data and filters, improving overall state management and performance. - Cleaned up imports and removed unused code to enhance maintainability.
…artner details display - Changed the business base URL to use the development URL when on localhost or dev environments, ensuring proper data fetching during development. - Added overflowWrap style to partner website display for improved text handling and readability.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…PartnersFilter and Partner components - Updated PartnersFilter to conditionally render the Messenger checkbox based on the active network, enhancing user experience. - Refactored data access in Partner component to use optional chaining for safer attribute retrieval, improving code robustness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Improve partner filtering by fetching all data at once and storing it locally for frontend filtering. This resolves delays, errors in filtering multiple business fields, and limitations with polymorphic relations like media fields.