Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Deposits fixes #334

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Create Deposits fixes #334

merged 3 commits into from
Nov 6, 2023

Conversation

aeddaqqa
Copy link

@aeddaqqa aeddaqqa commented Nov 5, 2023

This PR addresses two key improvements:

  • It focuses on refining the styling of the 'Create DepositOffer' component, enhancing the overall user experience with a polished and consistent design.
  • Additionally, it includes a thorough refactor of the logic responsible for handling pending multisig transactions.

@aeddaqqa aeddaqqa requested a review from Ayagoumi November 5, 2023 20:47
@aeddaqqa aeddaqqa marked this pull request as ready for review November 5, 2023 20:48
Copy link

@Ayagoumi Ayagoumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeddaqqa aeddaqqa merged commit fec428f into suite Nov 6, 2023
4 checks passed
@aeddaqqa aeddaqqa deleted the deposits-fixes branch November 6, 2023 13:00
Ayagoumi added a commit that referenced this pull request Dec 11, 2023
* feat: creating deposit Offers (#332)
* Create Deposits fixes (#334)
* refactor create offer single sig
* add multi-sig logic to create an offer form
* change duration from seconds to days
* fix check of displaying create offer form (#335)
* Bug fixes (#333)
* fix(send): show p-chain available amount instead of x-chain
* fix(style): center the NFT card content in the history panel
* fix(History): showing p-chain address in the history panel
* fix(style): add border-radius to confirmation background
* fix(multi-sig-wallet): update console handling in the msig section
* chore(locale): update warning message for list loading
* feat(balance): deduct the gas fee from the native token balance calculation
* fix(validator): Correct uptime calculation to prevent 10000% display
* Refactor font styling to use mixins scss file (#173)
* Refactor font styling to use mixins scss file
* fix(typography): size adjustment
* Merge branch 'suite' into fonts-refactor

---------

Co-authored-by: Ayagoumi <[email protected]>
* improvement for creating offer form (#336)
* improvement in creating an offer form
* fix catching  signavault errors
* improvement for msg part of creating an offer
* Fix add validator (#337)
* fix(add validator): date picker, formatting, and style
* Fix: multi-sig alias address validation
* fix(add-validator): fix start and end time starting time & style adjustments
* fix(history): network explorer URL check
* several fixes for deposit offer (#339)
* fix vesting period label (#341)
* Fix(add validator): duration calculation & update for when the wallet changes (#340)
* Fix(add validator): duration calculation & update for when the wallet changes
* Fix(add-validator): lifecycle method and add password input type
* Refactor ClaimRewards component

---------

Co-authored-by: Achraf Eddaqqaq <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants