Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suite #342

Merged
merged 10 commits into from
Dec 11, 2023
Merged

Suite #342

merged 10 commits into from
Dec 11, 2023

Conversation

Ayagoumi
Copy link

@Ayagoumi Ayagoumi commented Dec 8, 2023 •
edited
Loading

Pull Request: Enhancement and Refactoring of Deposit Offers Functionality

This pull request introduces significant enhancements and bug fixes in the deposit offers and add validator features, along with comprehensive improvements in UI/UX, functionality, and code maintainability.

Features

Enhanced Deposit Offers Creation

  • Refactored 'create offer' logic for single signatures.
  • Integrated multisig capabilities into the 'create offer' form.
  • Transitioned offer duration input from seconds to a more user-friendly day-based format.

Bug Fixes

UI and Functionality Enhancements

  • Resolved inconsistencies in the display of the 'create offer' form.
  • Altered the balance display to show P-Chain amounts correctly.
  • Centrally aligned NFT card content in the history panel for improved aesthetics.
  • Corrected P-Chain address displays in the history panel.
  • Added a border radius to the confirmation background for enhanced UI appeal.

Application Stability and Performance

  • Updated console handling within the multisig wallet segment.
  • Corrected uptime calculations in the validator to eliminate erroneous displays.
  • Refined font styling using SCSS mixins for a consistent and professional look.

Localization and User Messaging

  • Improved the clarity and informative aspect of warning messages related to list loading.

Functionality Enhancements

  • Implemented gas fee deduction from native token balance calculations to ensure accuracy.
  • Improved error handling mechanisms, focusing on Signavault errors.
  • Enhanced the messaging component of the 'create offer' process for better user guidance.

Validator and Date Management

  • Addressed issues in the 'add validator' section, including date picker functionality, formatting, and styling.
  • Enhanced multi-signature alias address validation for increased security.
  • Refined duration calculation in the 'add validator' section to adapt to wallet changes.
  • Improved lifecycle methods and added password input types in the 'add-validator' component for heightened security.

Additional Improvements

  • Executed specific fixes and refinements to bolster the deposit offer feature.
  • Unified font styling across the platform for a seamless visual experience.
  • Updated the vesting period label for clearer understanding.
  • Rectified network explorer URL checks to enhance operational reliability.

aeddaqqa and others added 10 commits November 3, 2023 07:43
@aeddaqqa
feat: creating deposit Offers (#332)
9cfbd28
@aeddaqqa
Create Deposits fixes (#334)
fec428f 
* refactor create offer single sig

* add multisig logic to create offer form

* change duration from seconds to days
@aeddaqqa
fix check of displaying create offer form (#335)
33121ad
@Ayagoumi
Bug fixes (#333)
3f73d40 
* fix(send): show p-chain available amount instead of x-chain

* fix(style): center the NFT card content in history panel

* fix(History): showing p-chain address in the history panel

* fix(style): add border radius to confirmation background

* fix(multisig-wallet): update console handling in the msig section

* chore(locale): update warning message for list loading

* feat(balance): deduct gas fee from native token balance calculation

* fix(validator): Correct uptime calculation to prevent 10000% display
@aeddaqqa @Ayagoumi
Refactor font styling to use mixins scss file (#173)
d17c845 
* Refactor font styling to use mixins scss file

* fix(typography): size adjustment

* Merge branch 'suite' into fonts-refactor

---------

Co-authored-by: Ayagoumi <[email protected]>
@aeddaqqa
improvement for create offer form (#336)
7347f63 
* improvement for create offer form

* fix catching  signavault errors

* improvement for msg part of create offer
@Ayagoumi
Fix add validator (#337)
7c86f2d 
* fix(add validator): date picker, formatting, and style
* Fix: multi sig alias address validation
* fix(add-validator): fix start and end time starting time & style adjustments
* fix(history): network explorer URL check
@aeddaqqa
several fixes for deposit offer (#339)
94a5952
@aeddaqqa
fix vesting period label (#341)
281a241
@Ayagoumi
Fix(add validator): duration calculation & update for when the wallet…
7406386 
… changes (#340)

* Fix(add validator): duration calculation & update for when the wallet changes

* Fix(add-validator): lifecycle method and add password input type

* Refactor ClaimRewards component
@Ayagoumi Ayagoumi requested a review from aeddaqqa December 8, 2023 09:16
@Ayagoumi Ayagoumi merged commit 6aa3240 into suite-c4t Dec 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mo-c4t mo-c4t mo-c4t approved these changes

@aeddaqqa aeddaqqa aeddaqqa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ayagoumi @aeddaqqa @mo-c4t