[MULTISIG] Storing Alias definitions in Smart Contract state #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnowosie
force-pushed
the
pnowosie/persisting-multisig-definitions-in-sc
branch
from
2b8694e to
1db886b
Compare
pnowosie
force-pushed
the
pnowosie/persisting-multisig-definitions-in-sc
branch
from
1db886b to
b355dc3
Compare
pnowosie
commented
Apr 13, 2023
| @@ -47,6 +52,8 @@ type UnsignedImportTx struct { | |||
| ImportedInputs []*avax.TransferableInput `serialize:"true" json:"importedInputs"` | |||
| // Outputs | |||
| Outs []EVMOutput `serialize:"true" json:"outputs"` | |||
| // MultisigAliases are filled on SemanticVerify where SharedMemory data is fetched and are used in EVMStateTransfer | |||
| MultisigAliases []*multisig.AliasWithNonce `serialize:"false"` | |||
There was a problem hiding this comment.
Reason for this non-serializable field is to remember aliases which are collected in SemanticVerify for EVMStateTransfer where we're able to persist them in SC state.
Also: maybe I should make it unexportable outside of the module (rename to multisigAliases )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
PR adds exported MultisigAliases (from ShM along with UTXOs, see: #65, #caminogo/217) to MultisigAlias contract's state
How this works
How to store solidity structures from the Go code is explained in the article
How this was tested
Unit test