Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TECH-631: Atomic C-Chain txs on the cblocks query #31

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

charalarg
Copy link

@charalarg charalarg commented Feb 2, 2023

Description

This PR adds the atomic c-chain txs on the c-blocks query response in order to be visible in the block explorer's c-chain view.
These txs are also taken into account by the aggregation calculations.

Changes

  • Updated indexes and fields of cvm_transactions_atomic table, in order to be consistent with the cvm_transactions_txdata table.
  • Changed the way that the atomic txs are being indexed in order to contain all the appropriate data.
  • Implemented the c-blocks query in a way that it also contains the atomic-txs.
  • Updated the aggregation calculations in order to take in to consideration the atomic-txs, too.

Example

Block explorer showing an import tx:

image

Remarks

By clicking the txID or the avax address (From or To address, depends on if the tx is an import or an export ones) of this tx,
we reach empty tables. For the time being these fields could become unclickable from the block explorer because this functionality is out of scope for this PR and needs further refinement.

@charalarg charalarg force-pushed the feature/TECH-631-cbocks-atomic-txs branch from 88860af to 889d43d Compare February 2, 2023 09:49
@charalarg charalarg force-pushed the feature/TECH-631-cbocks-atomic-txs branch from 889d43d to 1f0ebaa Compare March 2, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant