Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add BADDOG currency to chihuahua.json #368

Merged
merged 17 commits into from
Jan 18, 2024
Merged

Conversation

SmolFatality
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Jan 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keplr-chain-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 3:41am

@HeesungB
Copy link
Collaborator

HeesungB commented Jan 7, 2024

@SmolFatality Please add an image like the link example below.

{chiainIdentifier}/{factory token minimal denom}/{minimal denom}.png

https://github.com/chainapsis/keplr-chain-registry/tree/main/images/osmosis/factory/osmo14klwqgkmackvx2tqa0trtg69dmy0nrg4ntq4gjgw2za4734r5seqjqm4gm

@SmolFatality
Copy link
Contributor Author

Sorry was in the process and got sidetracked irl. Doing so now.

@SmolFatality
Copy link
Contributor Author

Added correct sized img

@HeesungB
Copy link
Collaborator

HeesungB commented Jan 9, 2024

@SmolFatality Can you move image file to /images/chihuahua/factory/chihuahua1x4q2vkrz4dfgd9hcw0p5m2f2nuv2uqmt9xr8k2/achihuahuawifhat.png location?

This is the factory token image storage rule.

@SmolFatality
Copy link
Contributor Author

Yes

Copy link
Contributor Author

@SmolFatality SmolFatality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed image issue, sorry it took so long. Thanks for the review.

@SmolFatality
Copy link
Contributor Author

@HeesungB

@HeesungB
Copy link
Collaborator

@SmolFatality Could you move image to images/chihuahua/factory/chihuahua1x4q2vkrz4dfgd9hcw0p5m2f2nuv2uqmt9xr8k2/achihuahuawifhat.png?

and You should change image's name.

@SmolFatality
Copy link
Contributor Author

I thought I did that earlier. Let me double check.

@SmolFatality
Copy link
Contributor Author

done

@HeesungB
Copy link
Collaborator

@SmolFatality Oh Could you add factory directory?
Your image file is inimages/chihuahua/chihuahua1x4q2vkrz4dfgd9hcw0p5m2f2nuv2uqmt9xr8k2/achihuahuawifhat.png
But It will be in images/chihuahua/factory/chihuahua1x4q2vkrz4dfgd9hcw0p5m2f2nuv2uqmt9xr8k2/achihuahuawifhat.png

@SmolFatality
Copy link
Contributor Author

@HeesungB man, i feel bad i had to annoy you too much. hopefully this is the last time.

@HeesungB
Copy link
Collaborator

@SmolFatality No It is okay! Thank you for contribution!

@HeesungB HeesungB merged commit 0168553 into chainapsis:main Jan 18, 2024
3 checks passed
@SmolFatality
Copy link
Contributor Author

How would I get prices added into keplr so people can see that?

@HeesungB
Copy link
Collaborator

@SmolFatality You can do this by registering on coingecko and adding it here.

mikluke pushed a commit to scorum/keplr-chain-registry that referenced this pull request Feb 13, 2024
* add BADDOG currency to chihuahua.json

* Add files via upload

* Update for png chihuahua.json

* Delete images/chihuahua/baddog-trans.png

* adding baddog.png with correct size

* Update chihuahua.json

* Delete images/chihuahua/baddog-trans.png

* Create chihuahua1x4q2vkrz4dfgd9hcw0p5m2f2nuv2uqmt9xr8k2

* Delete images/chihuahua/chihuahua1x4q2vkrz4dfgd9hcw0p5m2f2nuv2uqmt9xr8k2

* Create achihuahuawifhat.png

* Add files via upload

* Delete images/chihuahua/chihuahua1x4q2vkrz4dfgd9hcw0p5m2f2nuv2uqmt9xr8k2/achihuahuawifhat.png

* Create chihuahua1x4q2vkrz4dfgd9hcw0p5m2f2nuv2uqmt9xr8k2

* Delete images/chihuahua/factory/chihuahua1x4q2vkrz4dfgd9hcw0p5m2f2nuv2uqmt9xr8k2

* Create achihuahuawifhat.png

* Add files via upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants