Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BSKT to Kepler Contract Registry #27

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Add BSKT to Kepler Contract Registry #27

merged 4 commits into from
Mar 21, 2024

Conversation

crypt0xg
Copy link
Contributor

@crypt0xg crypt0xg commented Mar 6, 2024

No description provided.

@HeesungB
Copy link
Collaborator

@crypt0xg Could you check your file name? There is , before .json.
cosmos/injective/tokens/inj193340xxv49hkug7r65xzc0l40tze44pee4fj94,.json

crypt0xg
crypt0xg commented Mar 18, 2024
View reviewed changes
Copy link
Contributor Author

@crypt0xg crypt0xg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name updated

@crypt0xg
Copy link
Contributor Author

@HeesungB Apologies, was travelling for the last week and just seeing this now.

File name has been updated.

@HeesungB
Copy link
Collaborator

@crypt0xg Could you check your token name?

Fetched metadata is not same with the token metadata: (expected: {"name":"BSKT (Wormhole)","symbol":"BSKT","decimals":5}, actual: {"name":"Basket","symbol":"BSKT","decimals":5}), contract: inj193340xxv49hkug7r65xzc0l40tze44pee4fj94, chain: injective)

crypt0xg
crypt0xg commented Mar 19, 2024
View reviewed changes
Copy link
Contributor Author

@crypt0xg crypt0xg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name updated based on metadata expectations

@crypt0xg
Copy link
Contributor Author

@HeesungB Name has been updated as per comment

@crypt0xg
Copy link
Contributor Author

@HeesungB Is there anything else needed here?

@crypt0xg
Copy link
Contributor Author

@HeesungB Please do let us know what we need to do, to close this out.

@HeesungB
Copy link
Collaborator

@crypt0xg Sorry to late respond.

@HeesungB HeesungB merged commit 428ba2e into chainapsis:main Mar 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crypt0xg @HeesungB