-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wc-client: Secret Network support #728
Open
luca992
wants to merge
21
commits into
chainapsis:Thunnini/prepare-mobile-merge
Choose a base branch
from
luca992:secret-mobile-wc
base: Thunnini/prepare-mobile-merge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
wc-client: Secret Network support #728
luca992
wants to merge
21
commits into
chainapsis:Thunnini/prepare-mobile-merge
from
luca992:secret-mobile-wc
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to secret-mobile-wc
eshelB
suggested changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
once support for saving permits is implemented, getting a saved permit should be implemented in getSecret20ViewingKeyOrPermit
…to secret-mobile-wc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mobile Support Bounty
Implements APIs for the wc-client:
Notes:
I implemented
getSecret20ViewingKeyOrPermit
like this:As there is no permit functionality in keplr yet (that’s another bounty).
I’m not sure exactly what behavior you want when an error is thrown. But right now it will return an error instead of catching it and returning an object with both a null permit and a null viewing key
I also added
getSecret20ViewingKeyOrPermit
to thekeplr
interface and the all other provider implementationsDemo:
Screen.Recording.2023-05-22.at.6.37.02.PM.mov
Web App demo: the sample app from secretk
It shows the create viewing key message is being properly decrypted by keplr.
Screen.Recording.2023-05-23.at.8.17.58.PM.mov
For reference, this is what confirming a transaction looks like if keplr is not used for encryption (keplr cannot decrypt the message):