Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use chainer.as_variable #510

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muupan
Copy link
Member

@muupan muupan commented Jul 18, 2019

We no longer need to define our own function to wrap an array by a variable as chainer has as_variable since v4 (https://docs.chainer.org/en/v4.0.0/reference/generated/chainer.as_variable.html).

@toslunar
Copy link
Member

Do the args require grads?

@muupan
Copy link
Member Author

muupan commented Jul 18, 2019

Good point. It is difficult to guarantee that we won't compute gradient wrt mean or var of GaussianDistribution, so maybe we should not use chainer.as_variable here...

@muupan
Copy link
Member Author

muupan commented Jul 18, 2019

Some facts

@muupan muupan changed the title Use chainer.as_variable [WIP] Use chainer.as_variable Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants