Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deposit channel recycling for Solana #5411

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

syan095
Copy link
Contributor

@syan095 syan095 commented Nov 13, 2024

Added integration test for the recycling.

Pull Request

Closes: PRO-1684

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Allow deposit channel to recycle for Solana
Added integration test.

Added integration test for the recycling.
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 98.76543% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72%. Comparing base (420429c) to head (0e7e200).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
state-chain/cf-integration-tests/src/solana.rs 99% 0 Missing and 1 partial ⚠️
state-chain/chains/src/address.rs 80% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5411    +/-   ##
======================================
  Coverage     72%     72%            
======================================
  Files        487     489     +2     
  Lines      86183   86658   +475     
  Branches   86183   86658   +475     
======================================
+ Hits       61633   62146   +513     
+ Misses     21636   21589    -47     
- Partials    2914    2923     +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dandanlen dandanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @syan095

@dandanlen dandanlen added this pull request to the merge queue Nov 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 13, 2024
@syan095 syan095 added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 66b295b Nov 13, 2024
49 checks passed
@syan095 syan095 deleted the feat/solana-deposit-channel-recycle branch November 13, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants