Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr: delphioracle upsert #5

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

AndlerRL
Copy link
Member

@AndlerRL AndlerRL commented Jun 25, 2024

Changelog:

  • Added SQL upsert row length guard for error prone.
  • Improved the mapping and filtering of the delphioracles contract with their datapoints table, to limit the amount of updates per new block received.
  • Updated eosio + wharftkit dependencies.
  • Fixed the row upsert duplication. Now each row should be unique.
  • Improved row uniqueness (part of the fixed above).

TODO:

  • Limit even further the delphioracle updates: Use the declared env vars to set up a verification of new rows if they are worth to update or not for every XX minutes, declared as the value of this env var.
  • Improve some conditionals: At code level, there are some conditions that are redundant like for example row.length === 0... It is better and easier to read the !row.length

@AndlerRL AndlerRL changed the title Impr delphioracle upsert impr: delphioracle upsert Jun 25, 2024
@AndlerRL AndlerRL self-assigned this Jun 25, 2024
@AndlerRL AndlerRL added bug Something isn't working enhancement New feature or request labels Jun 25, 2024
@AndlerRL AndlerRL marked this pull request as draft June 25, 2024 16:43
@AndlerRL AndlerRL marked this pull request as draft June 25, 2024 16:43
@AndlerRL AndlerRL marked this pull request as draft June 25, 2024 16:43
@AndlerRL
Copy link
Member Author

My ETA for this one (for the TODO items) is tonight at my EOD. I noticed that there is a few to be done before to push it to master and prior to update the indexer on the related VM.

cc - @gaboesquivel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant