Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check if .so files are executable #1545

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Don't check if .so files are executable #1545

wants to merge 1 commit into from

Conversation

justinvreeland
Copy link
Contributor

@justinvreeland justinvreeland commented Oct 7, 2024 •
edited
Loading

Melange Pull Request Template

Functional Changes

  • This change can build all of Wolfi without errors (describe results in notes)

Notes:

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:

Linter

  • The new check is clean across Wolfi
  • The new check is opt-in or a warning

Notes:

@xnox xnox mentioned this pull request Oct 7, 2024
Merged
@xnox
Copy link
Contributor

xnox commented Oct 8, 2024

i like that you are scoping this to libraries only.

@justinvreeland justinvreeland marked this pull request as ready for review October 8, 2024 15:10
@justinvreeland justinvreeland changed the title [Draft] Don't check if .so files are executable Don't check if .so files are executable Oct 8, 2024
@justinvreeland justinvreeland marked this pull request as draft October 25, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinvreeland @xnox