Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow testing an index with a single image #78

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

stormqueen1990
Copy link
Contributor

@stormqueen1990 stormqueen1990 commented Oct 3, 2023

  • Fix the situation where an index with a single image errors out because GGCR expects a linux/amd64 image to be present in the index.

@stormqueen1990 stormqueen1990 marked this pull request as ready for review October 3, 2023 20:17
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm, I can add a test covering this scenario post-merge.

Thanks for making this change!

internal/provider/structure_test_data_source.go Outdated Show resolved Hide resolved
@stormqueen1990 stormqueen1990 enabled auto-merge (squash) October 3, 2023 20:29
Mauren Berti added 3 commits October 3, 2023 16:35
* Fix the situation where an index with a single image errors out because GGCR
  expects a linux/amd64 image to be present in the index.

Signed-off-by: Mauren Berti <[email protected]>
* Pick up the first image in the index and test it. In the future, change this
  to test all the images found in an index.

Signed-off-by: Mauren Berti <[email protected]>
Signed-off-by: Mauren Berti <[email protected]>
@stormqueen1990 stormqueen1990 merged commit 1028779 into chainguard-dev:main Oct 3, 2023
@stormqueen1990 stormqueen1990 deleted the fix/remote-get branch October 3, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants