Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license info and github slug to dataset #187

Merged
merged 16 commits into from
Jul 17, 2024

Conversation

LukvonStrom
Copy link
Contributor

Dear bump maintainers,

In this PR which is based on #186, I added the SPDX license identifiers and the clear github slug of the updated dependency and the consuming repository.

In addition I tried to add these changes into the miner as well, but the testsuite kept failing for me, making validation of those changes a bit hard.

I updated the JSON Schema as well.

Best regards,
Lukas

@frankreyesgarcia
Copy link
Collaborator

frankreyesgarcia commented Jul 10, 2024

@LukvonStrom Thanks for the contributions.
Can you resolve conflicts in the pull request?

@frankreyesgarcia
Copy link
Collaborator

frankreyesgarcia commented Jul 16, 2024

@LukvonStrom thanks for the contributions.

I fixed the problem with the validations.
Now I found that some of the JSON have the license data in different places which makes the validation fail.

The licenseInfo and githubRepoSlug fields are required but are missing or misplaced.

Can you verify that information?

Ex: https://github.com/LukvonStrom/bump/blob/add-license-info/data/benchmark/fd955874338ec4b678416f6d1b62a8b1f499d9e3.json

@LukvonStrom
Copy link
Contributor Author

This has been fixed now, I also added assertions to make sure this is constantly ensured. Apologies for the initial, somewhat naive implementation :)

@frankreyesgarcia frankreyesgarcia merged commit ae988ca into chains-project:main Jul 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants