Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions for building and testing #196

Merged
merged 6 commits into from
Jul 19, 2024
Merged

Conversation

ceyhunsen
Copy link
Member

Description

This PR introduces a Github Actions for building and testing Clementine on commits and PR's.

@ceyhunsen ceyhunsen requested a review from ekrembal July 16, 2024 14:20
@ceyhunsen ceyhunsen self-assigned this Jul 16, 2024
@ceyhunsen ceyhunsen marked this pull request as ready for review July 16, 2024 14:51
@ekrembal ekrembal requested a review from cetin July 16, 2024 14:51
.github/workflows/basic.yml Outdated Show resolved Hide resolved
cetin
cetin previously approved these changes Jul 19, 2024
Copy link
Contributor

@cetin cetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments, but they're not critical. All are for better readability. The rest of them are fine.

@ceyhunsen
Copy link
Member Author

I added some comments, but they're not critical. All are for better readability. The rest of them are fine.

Thanks for that, I applied them. Please do one final check and we will be good to merge. @cetin

@ceyhunsen ceyhunsen requested a review from cetin July 19, 2024 08:46
@ceyhunsen
Copy link
Member Author

Note: It is expected that main branch to fail these tests. Dev branch should pass though.

@byucesoy
Copy link

byucesoy commented Jul 19, 2024

Hi folks,

I just sent an e-mail to you, but since your repo is public, I'll write from here as well in case you miss the e-mail.

This is Burak from the Ubicloud team. You might have realized that the workflow job has been waiting in the queue for a long time. It seems we are not able to register our runner to be used in your repository. The process errors out with the following error message.

"Repository level self-hosted runners are disabled on this repository"

Maybe some setting is changed in your organization or repository or maybe some configuration is missing from this repository. If it was intentional, there is no action required, but it also means you won't be able to use Ubicloud runners. I just wanted to let you know about this issue in case the change was not intentional.

ekrembal
ekrembal previously approved these changes Jul 19, 2024
@cetin
Copy link
Contributor

cetin commented Jul 19, 2024

@byucesoy

Thank you for letting us know. We have realized this issue, and our organization admin is currently making changes to enable self-hosted runners for this repository. We appreciate your prompt notification and support in identifying the problem.

@ekrembal ekrembal changed the base branch from old-poc-main to main July 19, 2024 09:57
@ekrembal ekrembal dismissed their stale review July 19, 2024 09:57

The base branch was changed.

@ekrembal ekrembal changed the base branch from main to old-poc-main July 19, 2024 09:58
@ceyhunsen ceyhunsen changed the base branch from old-poc-main to main July 19, 2024 11:13
@ceyhunsen ceyhunsen changed the base branch from main to old-poc-main July 19, 2024 11:15
@ceyhunsen ceyhunsen merged commit 84b88d9 into old-poc-main Jul 19, 2024
1 check failed
@ceyhunsen ceyhunsen deleted the actions branch July 19, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants