Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate BitVM with dummy winternitz at init #498

Merged
merged 15 commits into from
Feb 6, 2025
Merged

Calculate BitVM with dummy winternitz at init #498

merged 15 commits into from
Feb 6, 2025

Conversation

ekrembal
Copy link
Member

@ekrembal ekrembal commented Feb 4, 2025

No description provided.

@ekrembal ekrembal mentioned this pull request Feb 4, 2025
Closed
@ekrembal ekrembal added the HOLD MERGE Hold the merge while you see this label label Feb 4, 2025
@ekrembal ekrembal marked this pull request as ready for review February 5, 2025 15:42
@ekrembal ekrembal requested review from ceyhunsen, mmtftr and ozankaymak and removed request for ceyhunsen and mmtftr February 5, 2025 15:42
ceyhunsen
ceyhunsen requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@ceyhunsen ceyhunsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are too many manual byte-by-byte copy code left untested. I think those needs test, if these new utils have a potential to change in the future.

core/src/utils.rs Outdated Show resolved Hide resolved
core/src/utils.rs Outdated Show resolved Hide resolved
core/src/utils.rs Outdated Show resolved Hide resolved
@ekrembal ekrembal removed the HOLD MERGE Hold the merge while you see this label label Feb 5, 2025
ceyhunsen
ceyhunsen approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@ceyhunsen ceyhunsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Still needs tests though.

@ekrembal
Copy link
Member Author

ekrembal commented Feb 6, 2025

We can add tests later, this is not the final way we will use BitVM anyways

@ekrembal ekrembal merged commit c3a2ed2 into dev Feb 6, 2025
9 checks passed
@ekrembal ekrembal deleted the ekrem/bitvm-improvments branch February 6, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceyhunsen ceyhunsen ceyhunsen approved these changes

@ozankaymak ozankaymak Awaiting requested review from ozankaymak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekrembal @ceyhunsen