identify: fix sorting of observed addresses (libp2p#2476)

chaitanyaprem · Aug 14, 2023 · e083078 · e083078
1 parent 646af49
commit e083078
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/p2p/protocol/identify/obsaddr.go b/p2p/protocol/identify/obsaddr.go
@@ -212,10 +212,13 @@ func (oas *ObservedAddrManager) filter(observedAddrs []*observedAddr) []ma.Multi
 	for pat := range pmap {
 		s := pmap[pat]
 
-		// We prefer inbound connection observations over outbound.
-		// For ties, we prefer the ones with more votes.
 		slices.SortFunc(s, func(first, second *observedAddr) int {
-			if first.numInbound > second.numInbound || len(first.seenBy) > len(second.seenBy) {
+			// We prefer inbound connection observations over outbound.
+			if first.numInbound > second.numInbound {
+				return -1
+			}
+			// For ties, we prefer the ones with more votes.
+			if first.numInbound == second.numInbound && len(first.seenBy) > len(second.seenBy) {
 				return -1
 			}
 			return 1